Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

fix: remove an unused channel that was locking the broadcast #433

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

Freyskeyd
Copy link
Member

Description

The broadcast on devnet-1 was stuck after some time.
It was because an unused channel was filling up by un-consumed messages and the N+1 message was waiting for slot that was never released.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd requested a review from a team as a code owner January 19, 2024 18:07
Copy link
Contributor

@gruberb gruberb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8fb4003) 66.95% compared to head (726af00) 68.72%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
+ Coverage   66.95%   68.72%   +1.77%     
==========================================
  Files         220      220              
  Lines       12109    12102       -7     
==========================================
+ Hits         8107     8317     +210     
+ Misses       4002     3785     -217     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gruberb gruberb merged commit 43c6fe5 into main Jan 19, 2024
21 checks passed
@gruberb gruberb deleted the fix/remove-unused-locking-channel branch January 19, 2024 19:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants