Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

chore: update SynchronizerService to remove unwrap #403

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

Freyskeyd
Copy link
Member

Description

During deployment we detected that some peer were not accessible leading to some method call failure on gRPC. This PR is fixing the panic.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd requested a review from a team as a code owner December 13, 2023 19:17
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (28a553b) 62.88% compared to head (f8d95f8) 62.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   62.88%   62.63%   -0.26%     
==========================================
  Files         220      220              
  Lines       11802    11801       -1     
==========================================
- Hits         7422     7391      -31     
- Misses       4380     4410      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Freyskeyd Freyskeyd merged commit b424aa9 into main Dec 13, 2023
21 checks passed
@Freyskeyd Freyskeyd deleted the fix/remove-failure-on-sync branch December 13, 2023 19:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants