Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

chore: adding no-color option to CLI #402

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Conversation

Freyskeyd
Copy link
Member

Description

Add --no-color flag and TOPOS_LOG_NOCOLOR env var to disable color on the CLI

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

In order to disable ANSI color on command line, both using --no-color and TOPOS_LOG_NOCOLOR env

Signed-off-by: Simon Paitrault <[email protected]>
@Freyskeyd Freyskeyd requested a review from a team as a code owner December 11, 2023 18:08
Signed-off-by: Simon Paitrault <[email protected]>
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (60f873c) 62.87% compared to head (6e2d7df) 62.77%.
Report is 1 commits behind head on main.

Files Patch % Lines
crates/topos/src/components/node/mod.rs 14.28% 6 Missing ⚠️
crates/topos/src/tracing.rs 0.00% 6 Missing ⚠️
crates/topos/src/components/regtest/mod.rs 0.00% 3 Missing ⚠️
crates/topos/src/components/node/commands.rs 0.00% 1 Missing ⚠️
crates/topos/src/options.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
- Coverage   62.87%   62.77%   -0.11%     
==========================================
  Files         220      220              
  Lines       11760    11774      +14     
==========================================
- Hits         7394     7391       -3     
- Misses       4366     4383      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Freyskeyd Freyskeyd merged commit 4989936 into main Dec 12, 2023
20 of 21 checks passed
@Freyskeyd Freyskeyd deleted the chore/adding-no-color-option branch December 12, 2023 09:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants