Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: refactor peer selection for synchronization #382

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Conversation

Freyskeyd
Copy link
Member

@Freyskeyd Freyskeyd commented Nov 23, 2023

Description

Switch from gatekeeper random peer to p2p layer random peer.
Basically dropping the support and management of the peers in the gatekeeper to only rely on the the network layer.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd marked this pull request as ready for review November 23, 2023 13:43
@Freyskeyd Freyskeyd requested a review from a team as a code owner November 23, 2023 13:43
@Freyskeyd Freyskeyd marked this pull request as draft November 23, 2023 13:44
@Freyskeyd Freyskeyd changed the title chore: wip feat: refactor peer selection for synchronization Nov 27, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (014ddf6) 62.79% compared to head (2f445c7) 62.84%.
Report is 3 commits behind head on main.

Files Patch % Lines
...-tce-synchronizer/src/checkpoints_collector/mod.rs 50.00% 3 Missing ⚠️
crates/topos-tce/src/lib.rs 0.00% 2 Missing ⚠️
crates/topos-p2p/src/command.rs 0.00% 1 Missing ⚠️
crates/topos-p2p/src/runtime/handle_command.rs 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
+ Coverage   62.79%   62.84%   +0.04%     
==========================================
  Files         219      220       +1     
  Lines       11812    11760      -52     
==========================================
- Hits         7417     7390      -27     
+ Misses       4395     4370      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Freyskeyd Freyskeyd marked this pull request as ready for review November 30, 2023 14:37
Signed-off-by: Simon Paitrault <[email protected]>
crates/topos-p2p/src/error.rs Show resolved Hide resolved
crates/topos-p2p/src/error.rs Outdated Show resolved Hide resolved
crates/topos-p2p/src/runtime/handle_command.rs Outdated Show resolved Hide resolved
crates/topos-tce-gatekeeper/src/builder.rs Show resolved Hide resolved
Signed-off-by: Simon Paitrault <[email protected]>
@Freyskeyd Freyskeyd merged commit 6982d33 into main Dec 4, 2023
21 checks passed
@Freyskeyd Freyskeyd deleted the feature/TP-787 branch December 4, 2023 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants