Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

fix: ci docker build #376

Merged
merged 1 commit into from
Nov 21, 2023
Merged

fix: ci docker build #376

merged 1 commit into from
Nov 21, 2023

Conversation

Freyskeyd
Copy link
Member

Description

Fixing the CI docker build

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd requested a review from a team as a code owner November 20, 2023 08:49
@Freyskeyd Freyskeyd changed the title fix: CI docker build fix: ci docker build Nov 20, 2023
@atanmarko
Copy link
Member

I don't really understand the changes here, I think better for tools team to review it

@Freyskeyd Freyskeyd force-pushed the chore/fixing-ci-docker branch 2 times, most recently from 81b186e to f3b6b75 Compare November 20, 2023 08:55
Copy link
Member

@sebastiendan sebastiendan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but would be great to have clear descriptions to understand what the issue was and how the fix solved the problem.

Copy link
Contributor

@gruberb gruberb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I removed the Extract metadata in my last PR. I thought we don't need it anymore. Sorry!

The broadcast_channel I assume is just a cleanup?

@dvdplm
Copy link
Contributor

dvdplm commented Nov 20, 2023

@Freyskeyd CI seems angry but it's not clear (to me) what the problem is. :/

Signed-off-by: Simon Paitrault <[email protected]>
@Freyskeyd Freyskeyd merged commit 46b2a94 into main Nov 21, 2023
18 checks passed
@Freyskeyd Freyskeyd deleted the chore/fixing-ci-docker branch November 21, 2023 15:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants