-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
==========================================
- Coverage 61.60% 61.38% -0.23%
==========================================
Files 219 219
Lines 12008 12109 +101
==========================================
+ Hits 7398 7433 +35
- Misses 4610 4676 +66 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the approach. I am just not sure to what extend we want to expand our test run time for this. I would personally rather test the error cases, and leave the node up
test for larger e2e
tests.
We also don't test here if the right components are being triggered based on the config file. So I am not 100% sure. Maybe others can weigh in as well.
@gruberb I think having basic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
ac6d4e9
to
035ac42
Compare
Description
Added test execution
topos node up
with parameters from environment and config file.Fixes TP-765
PR Checklist: