This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
feat: use protobuf messages for double echo #364
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
==========================================
+ Coverage 60.45% 60.52% +0.06%
==========================================
Files 230 232 +2
Lines 12013 12132 +119
==========================================
+ Hits 7263 7343 +80
- Misses 4750 4789 +39
☔ View full report in Codecov by Sentry. |
Freyskeyd
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some little updates need to be made but LGTM overall
atanmarko
force-pushed
the
feat/TP-108
branch
from
November 2, 2023 11:28
ea18cfa
to
6204fe7
Compare
atanmarko
force-pushed
the
feat/TP-108
branch
from
November 2, 2023 11:55
ffce193
to
4758934
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For double echo protocol, use protobuf message definitions and serialize messages using using grpc serialization instead of bincode.
Fixes TP-108
Additions and Changes
NetworkMessage
TceCommands
fromtopos-tce-transport
topos-tce-api
topos-crypto
PR Checklist: