Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: use protobuf messages for double echo #364

Merged
merged 12 commits into from
Nov 2, 2023
Merged

feat: use protobuf messages for double echo #364

merged 12 commits into from
Nov 2, 2023

Conversation

atanmarko
Copy link
Member

@atanmarko atanmarko commented Nov 1, 2023

Description

For double echo protocol, use protobuf message definitions and serialize messages using using grpc serialization instead of bincode.

Fixes TP-108

Additions and Changes

  • Changed NetworkMessage
  • Removed TceCommands from topos-tce-transport
  • Double echo proto messages and conversions defined in topos-tce-api
  • ValidatorId moved to topos-crypto

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@atanmarko atanmarko requested review from Nashtare and a team as code owners November 1, 2023 10:36
@atanmarko atanmarko self-assigned this Nov 1, 2023
@atanmarko atanmarko marked this pull request as draft November 1, 2023 10:36
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (bc5b48e) 60.45% compared to head (4758934) 60.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #364      +/-   ##
==========================================
+ Coverage   60.45%   60.52%   +0.06%     
==========================================
  Files         230      232       +2     
  Lines       12013    12132     +119     
==========================================
+ Hits         7263     7343      +80     
- Misses       4750     4789      +39     
Files Coverage Δ
crates/topos-api/build.rs 100.00% <100.00%> (ø)
...os-api/src/grpc/conversions/shared/v1/signature.rs 100.00% <100.00%> (ø)
crates/topos-api/src/grpc/mod.rs 75.00% <ø> (ø)
crates/topos-core/src/types.rs 100.00% <ø> (+2.98%) ⬆️
crates/topos-crypto/src/lib.rs 50.00% <ø> (ø)
crates/topos-crypto/src/messages.rs 93.10% <ø> (ø)
crates/topos-tce-broadcast/src/tests/mod.rs 100.00% <100.00%> (ø)
crates/topos-tce-transport/src/lib.rs 23.52% <ø> (-4.25%) ⬇️
crates/topos-tce/src/app_context/protocol.rs 77.41% <100.00%> (+3.34%) ⬆️
crates/topos-tce/src/lib.rs 0.00% <ø> (ø)
... and 5 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atanmarko atanmarko marked this pull request as ready for review November 1, 2023 13:17
Copy link
Member

@Freyskeyd Freyskeyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some little updates need to be made but LGTM overall

crates/topos-api/proto/topos/tce/v1/double_echo.proto Outdated Show resolved Hide resolved
crates/topos-api/proto/topos/tce/v1/double_echo.proto Outdated Show resolved Hide resolved
crates/topos-api/proto/topos/tce/v1/double_echo.proto Outdated Show resolved Hide resolved
crates/topos-api/proto/topos/tce/v1/double_echo.proto Outdated Show resolved Hide resolved
crates/topos-p2p/src/client.rs Outdated Show resolved Hide resolved
crates/topos-tce/src/app_context/network.rs Outdated Show resolved Hide resolved
crates/topos-tce/src/app_context/network.rs Show resolved Hide resolved
@atanmarko atanmarko merged commit 56558b1 into main Nov 2, 2023
21 checks passed
@atanmarko atanmarko deleted the feat/TP-108 branch November 2, 2023 12:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants