Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

chore: fixing requirement for docker github workflow #349

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

Freyskeyd
Copy link
Member

@Freyskeyd Freyskeyd commented Oct 25, 2023

Description

Fixing the requirement of the docker GitHub workflow, removing the require: true change to allow the use of the default value.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd requested a review from a team as a code owner October 25, 2023 08:08
@Freyskeyd Freyskeyd force-pushed the chore/fixing-requirement-docker-workflow branch from ea84b52 to 6afe5ea Compare October 25, 2023 08:10
@Freyskeyd Freyskeyd force-pushed the chore/fixing-requirement-docker-workflow branch 9 times, most recently from 29da4d9 to 743bfdb Compare October 25, 2023 19:43
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (74babd1) 59.84% compared to head (47e6d58) 59.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
- Coverage   59.84%   59.84%   -0.01%     
==========================================
  Files         230      230              
  Lines       11985    12000      +15     
==========================================
+ Hits         7173     7181       +8     
- Misses       4812     4819       +7     
Files Coverage Δ
crates/topos-p2p/src/behaviour/grpc/connection.rs 68.42% <ø> (-6.58%) ⬇️
crates/topos-tce-storage/src/epoch/tables.rs 96.77% <75.00%> (-3.23%) ⬇️
crates/topos-tce-storage/src/index/mod.rs 97.05% <75.00%> (-2.95%) ⬇️
crates/topos-wallet/src/lib.rs 0.00% <0.00%> (ø)
crates/topos-tce-storage/src/validator/tables.rs 94.44% <72.72%> (-5.56%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Freyskeyd Freyskeyd force-pushed the chore/fixing-requirement-docker-workflow branch 11 times, most recently from 9e0a9b0 to 9bf34a2 Compare October 26, 2023 19:15
@Freyskeyd Freyskeyd marked this pull request as draft October 27, 2023 07:45
@Freyskeyd Freyskeyd force-pushed the chore/fixing-requirement-docker-workflow branch from 9bf34a2 to a1f2a03 Compare October 27, 2023 08:20
@Freyskeyd Freyskeyd force-pushed the chore/fixing-requirement-docker-workflow branch 5 times, most recently from 3ee53ce to 689ea2c Compare October 27, 2023 09:36
Signed-off-by: Simon Paitrault <[email protected]>
@Freyskeyd Freyskeyd force-pushed the chore/fixing-requirement-docker-workflow branch from 689ea2c to 47e6d58 Compare October 27, 2023 09:45
@Freyskeyd Freyskeyd marked this pull request as ready for review October 27, 2023 09:48
Copy link
Contributor

@gruberb gruberb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 💅

@gruberb gruberb mentioned this pull request Oct 27, 2023
4 tasks
@Freyskeyd Freyskeyd merged commit 065ddb8 into main Oct 27, 2023
34 of 38 checks passed
@Freyskeyd Freyskeyd deleted the chore/fixing-requirement-docker-workflow branch October 27, 2023 12:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants