This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
chore: fixing requirement for docker github workflow #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Paitrault <[email protected]>
Freyskeyd
force-pushed
the
chore/fixing-requirement-docker-workflow
branch
from
October 25, 2023 08:10
ea84b52
to
6afe5ea
Compare
atanmarko
approved these changes
Oct 25, 2023
Freyskeyd
force-pushed
the
chore/fixing-requirement-docker-workflow
branch
9 times, most recently
from
October 25, 2023 19:43
29da4d9
to
743bfdb
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
==========================================
- Coverage 59.84% 59.84% -0.01%
==========================================
Files 230 230
Lines 11985 12000 +15
==========================================
+ Hits 7173 7181 +8
- Misses 4812 4819 +7
☔ View full report in Codecov by Sentry. |
Freyskeyd
force-pushed
the
chore/fixing-requirement-docker-workflow
branch
11 times, most recently
from
October 26, 2023 19:15
9e0a9b0
to
9bf34a2
Compare
dvdplm
approved these changes
Oct 27, 2023
Freyskeyd
force-pushed
the
chore/fixing-requirement-docker-workflow
branch
from
October 27, 2023 08:20
9bf34a2
to
a1f2a03
Compare
Freyskeyd
force-pushed
the
chore/fixing-requirement-docker-workflow
branch
5 times, most recently
from
October 27, 2023 09:36
3ee53ce
to
689ea2c
Compare
Signed-off-by: Simon Paitrault <[email protected]>
Freyskeyd
force-pushed
the
chore/fixing-requirement-docker-workflow
branch
from
October 27, 2023 09:45
689ea2c
to
47e6d58
Compare
gruberb
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 💅
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing the
requirement
of the docker GitHub workflow, removing therequire: true
change to allow the use of the default value.PR Checklist: