This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freyskeyd
force-pushed
the
doc/improve-broadcast-doc
branch
from
October 18, 2023 13:03
d85c011
to
75f179b
Compare
Signed-off-by: Simon Paitrault <[email protected]>
Freyskeyd
force-pushed
the
doc/improve-broadcast-doc
branch
from
October 18, 2023 13:06
75f179b
to
be7d7e2
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #342 +/- ##
==========================================
+ Coverage 60.73% 60.77% +0.04%
==========================================
Files 232 232
Lines 12135 12133 -2
==========================================
+ Hits 7370 7374 +4
+ Misses 4765 4759 -6
☔ View full report in Codecov by Sentry. |
dvdplm
reviewed
Oct 18, 2023
dvdplm
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please!
gruberb
reviewed
Oct 18, 2023
hadjiszs
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also several occurrences of broadcasted
where broadcast
seems better.
Signed-off-by: Simon Paitrault <[email protected]>
Freyskeyd
force-pushed
the
doc/improve-broadcast-doc
branch
from
October 19, 2023 08:42
8b11f94
to
16cb576
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding some documentation about the
topos-tce-broadcast
cratePR Checklist: