This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
feat(p2p/grpc): creating gRPC behaviour #331
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freyskeyd
force-pushed
the
feature/create-grpc-behaviour
branch
from
October 9, 2023 18:12
496fcbd
to
5534046
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #331 +/- ##
==========================================
+ Coverage 60.90% 61.05% +0.15%
==========================================
Files 226 237 +11
Lines 12310 13248 +938
==========================================
+ Hits 7497 8089 +592
- Misses 4813 5159 +346
☔ View full report in Codecov by Sentry. |
Freyskeyd
force-pushed
the
feature/create-grpc-behaviour
branch
8 times, most recently
from
October 10, 2023 13:43
db66cf4
to
f6f1936
Compare
Signed-off-by: Simon Paitrault <[email protected]>
Signed-off-by: Simon Paitrault <[email protected]>
Freyskeyd
force-pushed
the
feature/create-grpc-behaviour
branch
from
October 10, 2023 15:32
f6f1936
to
2311ede
Compare
Freyskeyd
changed the title
feat(p2p/grpc): creating gRPC behaviour
feat(p2p/grpc): creating gRPC behaviour https://img.shields.io/badge/1%20PR-grpc%20over%20p2p-blue
Oct 11, 2023
Freyskeyd
changed the title
feat(p2p/grpc): creating gRPC behaviour https://img.shields.io/badge/1%20PR-grpc%20over%20p2p-blue
feat(p2p/grpc): creating gRPC behaviour 1[https://img.shields.io/badge/1%20PR-grpc%20over%20p2p-blue]()
Oct 11, 2023
Freyskeyd
changed the title
feat(p2p/grpc): creating gRPC behaviour 1[https://img.shields.io/badge/1%20PR-grpc%20over%20p2p-blue]()
feat(p2p/grpc): creating gRPC behaviour 1[https://img.shields.io/badge/1%20PR-grpc%20over%20p2p-blue](https://img.shields.io/badge/1%20PR-grpc%20over%20p2p-blue)
Oct 11, 2023
Freyskeyd
changed the title
feat(p2p/grpc): creating gRPC behaviour 1[https://img.shields.io/badge/1%20PR-grpc%20over%20p2p-blue](https://img.shields.io/badge/1%20PR-grpc%20over%20p2p-blue)
feat(p2p/grpc): creating gRPC behaviour ![https://img.shields.io/badge/1%20PR-grpc%20over%20p2p-blue](https://img.shields.io/badge/1%20PR-grpc%20over%20p2p-blue)
Oct 11, 2023
Freyskeyd
changed the title
feat(p2p/grpc): creating gRPC behaviour ![https://img.shields.io/badge/1%20PR-grpc%20over%20p2p-blue](https://img.shields.io/badge/1%20PR-grpc%20over%20p2p-blue)
feat(p2p/grpc): creating gRPC behaviour
Oct 11, 2023
4 tasks
dvdplm
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a big PR, good job! Can't say I understood the whole thing fully, but overall I think it's looking good. I'm approving this, but it would be good if you addressed the various nitpicks. The one true concern I have is the possibility of race conditions on RequestId
.
Signed-off-by: Simon Paitrault <[email protected]>
dvdplm
reviewed
Oct 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Next PR: #332
This PR adds the gRPC behaviour in order to use gRPC client/server with p2p TCP connections.
The goal is to be able to rely on protobuf schema to dictate our network behaviours, allowing any other services that use gRPC to communicate with us transparently.
It also prevents us to generate and deal with complex custom-made Client/Server.
It also eases the
request/response
between two nodes and encapsulate the logic into dedicated structsPR Checklist: