Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: node flag for external edge #330

Merged
merged 3 commits into from
Oct 11, 2023
Merged

feat: node flag for external edge #330

merged 3 commits into from
Oct 11, 2023

Conversation

atanmarko
Copy link
Member

Description

For topos node up cli command, added flag --external-edge-node indicating that edge process should not be started.

Sequencer will connect to the edge node pointed by configuration

Fixes TP-741

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@atanmarko atanmarko self-assigned this Oct 6, 2023
@atanmarko atanmarko requested a review from a team as a code owner October 6, 2023 13:57
crates/topos/src/components/node/commands/up.rs Outdated Show resolved Hide resolved
crates/topos/src/components/node/commands/up.rs Outdated Show resolved Hide resolved
crates/topos/src/components/node/mod.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (da2e946) 60.90% compared to head (a19f438) 60.88%.
Report is 4 commits behind head on main.

❗ Current head a19f438 differs from pull request most recent head 5dfa68d. Consider uploading reports for the commit 5dfa68d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
- Coverage   60.90%   60.88%   -0.02%     
==========================================
  Files         226      226              
  Lines       12310    12329      +19     
==========================================
+ Hits         7497     7507      +10     
- Misses       4813     4822       +9     
Files Coverage Δ
...opos-tce-broadcast/src/task_manager_futures/mod.rs 97.14% <100.00%> (+5.71%) ⬆️
crates/topos/src/components/node/services.rs 20.20% <ø> (+0.20%) ⬆️
crates/topos/src/config/genesis/mod.rs 96.05% <100.00%> (+0.05%) ⬆️
crates/topos/src/components/node/commands/up.rs 50.00% <0.00%> (+50.00%) ⬆️
crates/topos/src/components/node/mod.rs 38.36% <0.00%> (-3.71%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atanmarko atanmarko requested a review from dvdplm October 11, 2023 14:27
@atanmarko atanmarko merged commit fe8c952 into main Oct 11, 2023
18 checks passed
@atanmarko atanmarko deleted the feat/TP-741 branch October 11, 2023 14:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants