This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
feat: adding GraphQL Subscription #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
==========================================
+ Coverage 60.51% 60.93% +0.42%
==========================================
Files 225 226 +1
Lines 12054 12310 +256
==========================================
+ Hits 7294 7501 +207
- Misses 4760 4809 +49
☔ View full report in Codecov by Sentry. |
Freyskeyd
force-pushed
the
feature/tp-681
branch
from
3b47424
to
904c23e
Compare
Signed-off-by: Simon Paitrault <[email protected]>
Freyskeyd
force-pushed
the
feature/tp-681
branch
5 times, most recently
from
225362e
to
3d5b6b9
Compare
dvdplm
reviewed
Oct 6, 2023
Can you define the channels that you're talking about? We have many different kind |
Freyskeyd
force-pushed
the
feature/tp-681
branch
2 times, most recently
from
25da63e
to
a6f376b
Compare
gruberb
suggested changes
Oct 6, 2023
Freyskeyd
force-pushed
the
feature/tp-681
branch
from
a6f376b
to
01cb570
Compare
dvdplm
reviewed
Oct 9, 2023
Freyskeyd
force-pushed
the
feature/tp-681
branch
from
01cb570
to
885e74b
Compare
Signed-off-by: Simon Paitrault <[email protected]>
Freyskeyd
force-pushed
the
feature/tp-681
branch
from
885e74b
to
d334235
Compare
dvdplm
approved these changes
Oct 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is adding
GraphQLsubscriptions to the current API implementation. It introduces the basic functionality and creates the newTransientStreamstruct to manage those new streams.PR Checklist: