Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

fix: extract validator pubkeys from genesis #325

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Conversation

dvdplm
Copy link
Contributor

@dvdplm dvdplm commented Oct 5, 2023

Refactor extraction of validators from the genesis file.

@dvdplm dvdplm requested a review from a team as a code owner October 5, 2023 07:48
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (705b97e) 60.52% compared to head (0d9983b) 60.50%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
- Coverage   60.52%   60.50%   -0.03%     
==========================================
  Files         225      225              
  Lines       12049    12058       +9     
==========================================
+ Hits         7293     7296       +3     
- Misses       4756     4762       +6     
Files Coverage Δ
crates/topos/src/config/genesis/mod.rs 96.00% <94.44%> (+0.22%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gruberb
Copy link
Contributor

gruberb commented Oct 5, 2023

Is there a reasoning behind this refactor?

Copy link
Contributor

@gruberb gruberb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although personally I like the previous version, it's slightly easier to follow and understand.

@dvdplm
Copy link
Contributor Author

dvdplm commented Oct 6, 2023

Is there a reasoning behind this refactor?

Not really, nothing beyond me reading code trying to fix a different problem and fixing a few warts and unneeded allocations.

@dvdplm dvdplm merged commit 4ce1428 into main Oct 6, 2023
20 checks passed
@dvdplm dvdplm deleted the dp-genesis-parsing branch October 6, 2023 09:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants