This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
feat: use constant-time Base64 encoding #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have the `base64ct` crate in the repo (dep of ethers I believe) and I think one is enough! It is also constant time, which is strictly better than the current `base64` and seem to have a better API.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
==========================================
- Coverage 60.44% 60.41% -0.03%
==========================================
Files 225 225
Lines 11976 11967 -9
==========================================
- Hits 7239 7230 -9
Misses 4737 4737
☔ View full report in Codecov by Sentry. |
Freyskeyd
approved these changes
Sep 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have the
base64ctcrate in the repo (dep ofethers I believe) and I think one is enough! It is also
constant time, which is strictly better than the current
base64and seem to have a better API.