-
Notifications
You must be signed in to change notification settings - Fork 5
fix: block handling during certificate generation #471
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #471 +/- ##
==========================================
- Coverage 71.96% 71.86% -0.10%
==========================================
Files 225 225
Lines 12659 12675 +16
==========================================
- Hits 9110 9109 -1
- Misses 3549 3566 +17 ☔ View full report in Codecov by Sentry. |
I don't fully understand why we keep the finalized blocks in linked list as opposed to a vec or a hashmap, but that's not the main point of this pr. |
We remove blocks from the beginning and add them to the end of the list and they need to keep order. I believe a linked list is the most optimal structure for this. VecDeque could also do the job (but less optimal if a number of blocks grows a lot because it is a ring buffer) |
Description
Handle removal of subnet blocks from the list when generating certificates
Fixes TP-786
PR Checklist: