This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freyskeyd
force-pushed
the
chore/improve-delivery-time
branch
2 times, most recently
from
February 29, 2024 15:50
408ea1b
to
707fe93
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
==========================================
+ Coverage 71.60% 71.95% +0.35%
==========================================
Files 225 225
Lines 12504 12659 +155
==========================================
+ Hits 8953 9109 +156
+ Misses 3551 3550 -1 ☔ View full report in Codecov by Sentry. |
Freyskeyd
force-pushed
the
chore/improve-delivery-time
branch
2 times, most recently
from
March 6, 2024 20:56
4217661
to
22cf5ba
Compare
Freyskeyd
force-pushed
the
chore/improve-delivery-time
branch
2 times, most recently
from
March 8, 2024 06:30
7bff5e9
to
cc5d681
Compare
dvdplm
reviewed
Mar 8, 2024
dvdplm
reviewed
Mar 8, 2024
dvdplm
suggested changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need a better PR description to give me the context for these changes. I'm too slow to review this otherwise.
gruberb
reviewed
Mar 12, 2024
Freyskeyd
force-pushed
the
chore/improve-delivery-time
branch
3 times, most recently
from
March 12, 2024 14:40
ae3e1b5
to
e5c3dc1
Compare
gruberb
approved these changes
Mar 12, 2024
Freyskeyd
force-pushed
the
chore/improve-delivery-time
branch
from
March 12, 2024 14:46
e5c3dc1
to
5a97b89
Compare
Signed-off-by: Simon Paitrault <[email protected]>
Signed-off-by: Simon Paitrault <[email protected]>
Signed-off-by: Simon Paitrault <[email protected]>
Freyskeyd
force-pushed
the
chore/improve-delivery-time
branch
from
March 12, 2024 16:29
5a97b89
to
dc67f92
Compare
dvdplm
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, but I have a bunch of questions.
Signed-off-by: Simon Paitrault <[email protected]>
Freyskeyd
force-pushed
the
chore/improve-delivery-time
branch
from
March 12, 2024 17:59
dc67f92
to
faf394d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors a bit the workflow that trigger new certs for delivery.
It also adds new queries on GraphQL in order to extract context from nodes.
Previous refactorization introduced
pull
mechanism on thebroadcast
where thetask
manager where actively pulling the nextcertificate
from thepending_pool
, the setup was to allow the broadcast to start consuming thepending_pool
when ready. However, a corner case exists that this PR is solving:pending_pool
checking tick is 10sec (1sec in reality) and tick atS0
certificate A
arrives on the node, is valid and can be delivered atS2
pending_pool
checking tick execute atS10
certificate A
is being broadcastBetween
S2
andS10
the certificate is waiting in the pending_pool for nothing.The changes are modifying this and do:
pending_pool
checking tick is 10sec (1sec in reality) and tick atS0
certificate A
arrives on the node, is valid and can be delivered atS2
broadcast
command is sent to thetask manager
atS2
, the task manager check the precedence of the certificate and see that the parent is deliveredcertificate A
is being broadcastpending_pool
checking tick execute atS10
Next / Questions / Options
pending_pool
tick could be set to a lower value or even switched to a proper channel between thepending_pool
and thetask_manager
PR Checklist: