This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
fix: remove duplicated certificate push on gossipsub #458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The initial sender is supposed to be the only one to publish the Certificate on the gossipsub topic
topos_gossip
. The initial sender is the one who receives the Certificate from the gRPC API and not from gossipsub.The rework on the storage by moving the management of the pending and precedence pool on the storage layer introduced the loss of the origin of the Certificate (whether it is received from gossipsub or grpc), consequently, the message was pushed by everyone on the
topos_gossip
topic on both cases since this storage rework.Additions and Changes
(PeerId, nonce)
, so we had as many duplicate of Certificate as the number of peershash(payload)
, consequently the other peers will detect the payload being the same, so it will not be published nor downloaded multiple timesPR Checklist: