Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting deprecation warning when running vscode extension updates #730

Closed
dannysteenman opened this issue Mar 5, 2024 · 4 comments
Closed
Labels
C-bug Something isn't working

Comments

@dannysteenman
Copy link

dannysteenman commented Mar 5, 2024

Erroneous Behavior

Running Visual Studio Code extensions updates causes the following warning:

── 08:46:18 - Visual Studio Code extensions ────────────────────────────────────
Updating extensions: ms-python.vscode-pylance
(node:26728) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use `Electron --trace-deprecation ...` to show where the warning was created)
Extension 'ms-python.vscode-pylance' v2024.2.3 was successfully updated.

Expected Behavior

No warning messages during updates

Steps to reproduce

Have an outdated vscode extension and then run the topgrade command

Possible Cause (Optional)

It's using an old method of buffer which is deprecated: https://stackoverflow.com/questions/52165333/deprecationwarning-buffer-is-deprecated-due-to-security-and-usability-issues

Additional Details

  • OS: macOS 14.3.1 23D60 arm64

  • Shell: zsh 5.9

  • Topgrade 14.0.1

  • Nodejs v20.11.1

  • Installation
    Homebrew

  • Topgrade version (topgrade -V)

  • Topgrade 14.0.1

Verbose Output (topgrade -v)


@dannysteenman dannysteenman added the C-bug Something isn't working label Mar 5, 2024
@SteveLauC
Copy link
Member

Can you reproduce this with:

$ code --update-extensions

@dannysteenman
Copy link
Author

Can you reproduce this with:

$ code --update-extensions

All my extensions are up to date so I cannot reproduce it at the moment. However I looked into it further and it seems like a vscode issue: microsoft/vscode#82524

@SteveLauC
Copy link
Member

Yeah, I think this is an issue of VSCode rather than Topgrade, Topgrade is simply a wrapper that tries to execute code --update-extensions

@dannysteenman
Copy link
Author

yeah I thought so, let's close this issue. thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants