Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable selection of Community Review type for Design challenges #995

Closed
vikasrohit opened this issue Dec 16, 2020 · 2 comments
Closed

Disable selection of Community Review type for Design challenges #995

vikasrohit opened this issue Dec 16, 2020 · 2 comments

Comments

@vikasrohit
Copy link

Expected behavior

WM should not allow editing the review type for design challenges

Actual behavior

As of now it allows user to edit the review type for a design challenge which gets overridden once the legacy challenge is created because of a business rule which does not allow review type to be community for a design challenge.

Steps to reproduce the problem

  • Create a design challenge
  • Choose Community as review type
  • Save as Draft and then Activate it
  • Wait for 3-5 minutes to sync to settle down
  • Now, edit the activated challenge and observe that Review type is set to Internal now.

Screenshot/screencast

Screen Shot 2020-12-16 at 9 36 24 AM

--

Environment

  • OS: Any
  • Browser (w/version): Any
  • User role (client, copilot or manager): Copilot/Manager
  • Account used: N/A
@vikasrohit
Copy link
Author

Linking #979 for setting context of what was the actual issue for which we are going to apply this approach.

@lakshmiathreya
Copy link

Verified in Prod.
Screenshot 2020-12-16 at 1 22 50 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants