Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in a "processing" status to reviews and reviewSummations #164

Open
cwdcwd opened this issue Feb 4, 2020 · 5 comments
Open

Add in a "processing" status to reviews and reviewSummations #164

cwdcwd opened this issue Feb 4, 2020 · 5 comments
Labels
enhancement New feature or request P2 Blocker-Must fix

Comments

@cwdcwd
Copy link
Contributor

cwdcwd commented Feb 4, 2020

add another status to the reviews and reviewSummations objects with a value of "processing"

@cwdcwd cwdcwd added enhancement New feature or request P2 Blocker-Must fix labels Feb 4, 2020
@callmekatootie
Copy link
Contributor

@cwdcwd reviewSummation does not have any status field. There's an isFinal flag on it though...

Do you mean to say that it will now contain a status field too?

@bountyC0d3r
Copy link
Collaborator

@callmekatootie yes, like the review will be having status for reviewSummation as well,
also, right now actual status values are in source js file; that should be moved to config; so that in future in case we need to add any new status, only need to modify config file

@callmekatootie
Copy link
Contributor

@callmekatootie
Copy link
Contributor

callmekatootie commented Feb 6, 2020

Additions:

  • review summation can also have status of queued and completed
  • in case status is queued or processing, for review summation, aggregateScore needs to be null

@callmekatootie
Copy link
Contributor

Pull Request ready - #167

@lakshmiathreya lakshmiathreya modified the milestone: v 1.1.0 May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Blocker-Must fix
Projects
None yet
Development

No branches or pull requests

4 participants