Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$80] Fix issues with the birth date field in Basic Info page #1660

Closed
ThomasKranitsas opened this issue Oct 4, 2018 · 24 comments
Closed

[$80] Fix issues with the birth date field in Basic Info page #1660

ThomasKranitsas opened this issue Oct 4, 2018 · 24 comments

Comments

@ThomasKranitsas
Copy link
Collaborator

  1. There's no way to go back in years. A user should be able to change the years without having to go back month by month.
  2. Currently, the default placeholder is today's date. Modify the DatePicker component in /src/shared/components/challenge-listing/Filters/DatePicker.jsx to be able to show a placeholder instead of today's date and update the basic info form to show a placeholder text instead of today's date.
@ThomasKranitsas
Copy link
Collaborator Author

Contest https://www.topcoder.com/challenges/30072312 has been created for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@ThomasKranitsas
Copy link
Collaborator Author

@topcoder-platform/topcodercompetitors this is open for pickup

@Gauravseta Gauravseta self-assigned this Oct 4, 2018
@ThomasKranitsas
Copy link
Collaborator Author

Contest https://www.topcoder.com/challenges/30072312 has been updated - it has been assigned to gauravseta.

This is an automated message for thomaskranitsas via Topcoder X

@Gauravseta
Copy link
Collaborator

@ThomasKranitsas
1.is changing library expected? such an implementation anywhere else where i can refer from?
2.what is the placeholder to be shown then?

@ThomasKranitsas
Copy link
Collaborator Author

Sorry for the delay! I missed the notification for this one.

  1. If possible, please don't change the library. If not, it should be fine.
  2. Birth date or Date of birth should work.

@ThomasKranitsas
Copy link
Collaborator Author

@Gauravseta what's the status on this one?

It's been quite some time without any progress.

@Gauravseta
Copy link
Collaborator

@ThomasKranitsas yes working on it. will update immediately.

@ThomasKranitsas
Copy link
Collaborator Author

Thank you! We need to complete this one ASAP

@ThomasKranitsas
Copy link
Collaborator Author

@Gauravseta still waiting for this one...

@ThomasKranitsas
Copy link
Collaborator Author

Please open it for pickup if you can't complete it in the next few hours. Thank you

@Gauravseta
Copy link
Collaborator

@ThomasKranitsas PR #1733

@Gauravseta
Copy link
Collaborator

@ThomasKranitsas waitign for review

@ThomasKranitsas
Copy link
Collaborator Author

@topcoder-platform/topcodercompetitors this is open for pickup. We need to fix this ASAP so please do not assign yourself if you're not sure you can fix it. I'll also increase the price a bit.

@ThomasKranitsas ThomasKranitsas changed the title [$40] Fix issues with the birth date field in Basic Info page [$80] Fix issues with the birth date field in Basic Info page Nov 26, 2018
@ThomasKranitsas
Copy link
Collaborator Author

Contest https://www.topcoder.com/challenges/30072312 has been updated - the new changes has been updated for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@ThomasKranitsas
Copy link
Collaborator Author

Contest https://www.topcoder.com/challenges/30072312 has been updated - it has been assigned to nahidshahin.

This is an automated message for thomaskranitsas via Topcoder X

@nahidshahin
Copy link
Contributor

nahidshahin commented Nov 26, 2018

@ThomasKranitsas the current library doesn't support previous/next year. There is a feature request at library's issue list react-dates/react-dates#1289.

So the option is either try to implement it in the current library or change the library.

Both option will be a bit time consuming.

@ThomasKranitsas
Copy link
Collaborator Author

how much time do you need?

@nahidshahin
Copy link
Contributor

@ThomasKranitsas 3rd option could be make the date field editable so that user can type previous year. It should be faster to implement.

@ThomasKranitsas
Copy link
Collaborator Author

Does that help react-dates/react-dates#1106 ?

@nahidshahin
Copy link
Contributor

Thanks @ThomasKranitsas, seems useful.

@nahidshahin
Copy link
Contributor

@ThomasKranitsas the library is working now. Need to fix CSS and few other issues.

@nahidshahin
Copy link
Contributor

@ThomasKranitsas raising PR shortly. Still need to fix some CSS issue.

@nahidshahin
Copy link
Contributor

@ThomasKranitsas raised PR #1769, addressed both 1 & 2

@ThomasKranitsas
Copy link
Collaborator Author

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30072312

This is an automated message for thomaskranitsas via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants