-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use summary as summary for converted ActivityPub objects #9823
Conversation
LGTM. This means such objects can't have a Content Warning though. Maybe use the title as a CW? |
I see no good reason to make people click show more, since both the title and the summary of a blog post are typically oriented towards being displayed in public view, while what would be actually hidden by the CW is the main text which is not displayed anyway (link). |
@@ -61,7 +61,7 @@ def process_status_params | |||
account: @account, | |||
text: text_from_content || '', | |||
language: detected_language, | |||
spoiler_text: text_from_summary || '', | |||
spoiler_text: converted_object_type? ? '' : (text_from_summary || ''), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be object[:sensitive] or something equivalent, so converted object types can still opt in to CWs
aren't there other converted object types besides articles though? |
If a video or image is marked sensitive, it will be hidden. Since they don't have other text, it doesn't make sense to to make people click "show more" for nothing. |
For non-Note objects,
summary
has a slightly different semantic meaning, and it doesn't make sense to use it as a content warning hiding the title and link to the article. So, for converted object types, display the title, then summary, then the link to the article.Fix #8609