Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attachment list fallback to public pages #9780

Merged
merged 2 commits into from
Jan 13, 2019

Conversation

ClearlyClaire
Copy link
Contributor

@ClearlyClaire ClearlyClaire commented Jan 10, 2019

Fixes #6714

I'm not too familiar with HAML, so I'm not sure if the fallback-as-a-block pattern makes a lot of sense.
Also, the code for rendering the list should probably be moved into another fragment or a helper.

Looks like this when the JS part hasn't loaded yet / if it doesn't load:
screenshot_2019-01-10 thib thib mastodev sitedethib com

@Gargron
Copy link
Member

Gargron commented Jan 11, 2019

Something is not right in the screenshot. Spacing to the icon as well as the color of the icon.

@Gargron
Copy link
Member

Gargron commented Jan 11, 2019

I think it should be possible to reuse the CSS of the AttachmentList component instead of redefining a copy.

@ClearlyClaire ClearlyClaire force-pushed the features/public-nojs-fallback branch 3 times, most recently from 9d72364 to e68fcbd Compare January 11, 2019 19:27
@ClearlyClaire
Copy link
Contributor Author

Oops, updated it, it looks like this now:
screenshot_2019-01-11 thib thib mastodev sitedethib com

@Gargron Gargron merged commit 4fb94c7 into mastodon:master Jan 13, 2019
@ClearlyClaire ClearlyClaire deleted the features/public-nojs-fallback branch March 14, 2019 15:46
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
* Add attachment list fallback to public pages

Fixes mastodon#6714

* Refactor attachments lists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants