Change the icon "reply" to "reply-all" when reply to other accounts #9378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
approved these changes
Nov 27, 2018
|
Shouldn't the icon still be "reply" if I'll end up replying to only one person, as is the case when that person mentioned only me? |
|
No; the doubled arrow represents more than one person in the conversation, not more than one recipient. |
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #9228 , the reply icon is unified to "reply" and the "Show thread" message is displayed in the self reply.
I agree with the display of the "Show thread" message.
However, after #9228, I think that it has become difficult to distinguish whether reply to other people is reply or call.
So I changed the icon to “reply-all” when replies to others.
How about this?
before:
after:
