Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include preview cards in status entity in REST API #9120

Merged
merged 3 commits into from
Oct 28, 2018

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Oct 27, 2018

Fix #1495
Fix #7208

image

A link can sometimes be fetched before the status is distributed. In other cases, first distribution includes no card. However, with the preview card resetting the cache of its status, the card will appear on subsequent loads. This might be acceptable.

When used from the in-stream status component, the card uses "compact" styling, which omits the description of the link and enforces a single-line rule for titles, and shrinks the thumbnail to 60px width, unless the preview is interactive. When the preview is interactive (e.g. YouTube), the thumbnail with action buttons is shown at 16:9, with no description section and no border.

@Gargron Gargron added api REST API, Streaming API, Web Push API work in progress Not to be merged, currently being worked on labels Oct 27, 2018
@Gargron Gargron added the ui Front-end, design label Oct 27, 2018
@Gargron Gargron removed the work in progress Not to be merged, currently being worked on label Oct 28, 2018
@Gargron Gargron merged commit 795f010 into master Oct 28, 2018
@Gargron Gargron deleted the feature-cards-in-stream branch October 28, 2018 05:39
TheInventrix added a commit to TheInventrix/mastodon that referenced this pull request Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api REST API, Streaming API, Web Push API ui Front-end, design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants