Make detailed-status__wrapper actually wrap detailed status #8547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.detailed-status__wrapper does not actually wrap the detailed status here
.detailed-status__wrapper now wraps the detailed status instead of the entire scrollable area
trwnh
changed the title
2 tasks
|
Can this be reviewed before 2.6.0? |
|
I'm sorry but could you please clarify the significance of this? Does something change in the style or JS behaviour? |
|
@Gargron Right now, when attempting to apply styles to the div immediately wrapping a detailed status, there is no easy selector that can be used to target it. It doesn't matter so much for the default style, but it makes custom styling harder than it should be. It's incredibly overly-broad in scope: It's also technically a bug, since the __wrapper class is immediately outside every other status class. |
Gargron
approved these changes
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.detailed-status__wrapper does not actually wrap the detailed status right now, as the class is applied to the scrollable div and not the focusable div.