Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order format has changed #58

Open
heretic13 opened this issue Aug 24, 2019 · 2 comments
Open

Order format has changed #58

heretic13 opened this issue Aug 24, 2019 · 2 comments

Comments

@heretic13
Copy link
Contributor

Hi.
The official documentation speaks of a single Order format. At the moment, it is a hybrid of the types Order and Order2.
string representaion:
{"Uuid":null,"OrderUuid":"8cb2a74d-9c3a-45aa-b63e-6f3622cdbebf","Exchange":"USD-BTC","OrderType":"LIMIT_SELL","Quantity":0.00937300,"QuantityRemaining":0.00937300,"Limit":10700.00000000,"CommissionPaid":0.00000000,"Price":0.00000000,"PricePerUnit":null,"Opened":"2019-08-21T14:21:36.99","Closed":null,"CancelInitiated":false,"ImmediateOrCancel":false,"IsConditional":false,"Condition":"NONE","ConditionTarget":null}
It would be nice to fix this

@heretic13
Copy link
Contributor Author

Updated Order format - file orders.go

type Order struct {
Uuid *string json:"Uuid"
OrderUuid string json:"OrderUuid"
Exchange string json:"Exchange"
OrderType string json:"OrderType"
Limit decimal.Decimal json:"Limit"
Quantity decimal.Decimal json:"Quantity"
QuantityRemaining decimal.Decimal json:"QuantityRemaining"
Price decimal.Decimal json:"Price"
PricePerUnit decimal.Decimal json:"PricePerUnit"
CommissionPaid decimal.Decimal
Opened jTime
Closed *jTime
CancelInitiated bool
ImmediateOrCancel bool
IsConditional bool
Condition string
ConditionTarget decimal.Decimal
}

@heretic13
Copy link
Contributor Author

create pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant