Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using floats in buy/sell functions, but decimal.Decimal everywhere else? #47

Open
payaaam opened this issue Jan 22, 2018 · 3 comments
Open

Using floats in buy/sell functions, but decimal.Decimal everywhere else? #47

payaaam opened this issue Jan 22, 2018 · 3 comments

Comments

@payaaam
Copy link
Contributor

payaaam commented Jan 22, 2018

What is the reasoning behind accepting floats in the buy/sell function calls? The library is using decimal.Decimal everywhere else and can easily pass those in and convert them to strings in the query params.

BuyLimit
SellLimit
Balance
@payaaam
Copy link
Contributor Author

payaaam commented Jan 22, 2018 •
edited
Loading

I created #48 in case you want to change it.

@payaaam
Copy link
Contributor Author

payaaam commented Jan 22, 2018

@toorop Was it intended to accept floats in those situations? I am happy with the merge, but I was expecting some pushback I suppose.

@toorop
Copy link
Owner

toorop commented Jan 23, 2018

Look at #23 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@toorop @payaaam