Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash due to race condition when creating log directory #168

Closed
onomated opened this issue Mar 20, 2018 · 2 comments
Closed

Crash due to race condition when creating log directory #168

onomated opened this issue Mar 20, 2018 · 2 comments
Milestone

Comments

@onomated
Copy link

Got crash report in Fabric:

Caused by java.lang.IllegalStateException: /storage/emulated/0/app_name/logs/app_name-latest.log should not have existing parent directory
       at ch.qos.logback.core.util.FileUtil.createMissingParentDirectories(Unknown Source)
       at ch.qos.logback.core.FileAppender.openFile(Unknown Source)
       at ch.qos.logback.core.FileAppender.start(Unknown Source)
       at ch.qos.logback.core.rolling.RollingFileAppender.start(Unknown Source)
...

Upon investigation, this issue has since been addressed in logback upstream, see JIRA issue and corresponding patch

Needs to be applied to https://github.com/tony19/logback-android/blob/master/logback-android/src/main/java/ch/qos/logback/core/util/FileUtil.java#L53

@tony19 tony19 added the bug label Mar 27, 2018
@tony19 tony19 added this to the 1.1.3 milestone Apr 11, 2018
@stale
Copy link

stale bot commented Jun 10, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 10, 2018
@tony19 tony19 added pinned and removed wontfix labels Jun 16, 2018
@tony19
Copy link
Owner

tony19 commented Sep 17, 2018

Fixed in v_1.1.3-1

@tony19 tony19 closed this as completed Sep 17, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants