Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS REVIEW #7306] Pin the dependencies #29

Closed
mberacochea opened this issue Nov 10, 2024 · 1 comment
Closed

[JOSS REVIEW #7306] Pin the dependencies #29

mberacochea opened this issue Nov 10, 2024 · 1 comment

Comments

@mberacochea
Copy link

Hi,

The setup.py file includes the tool dependencies, but they are not pinned to specific versions. Please pin the versions, as this will improve the stability of the packages; new versions of the dependencies may break Mashpit.

Additionally, Python has been gradually moving from setup.py to pyproject.toml as part of the packaging revamp. I would suggest migrating to pyproject.toml (https://packaging.python.org/en/latest/tutorials/packaging-projects/).

openjournals/joss-reviews#7306

Cheers

@tongzhouxu
Copy link
Owner

Mashpit is converted to pyproject.toml in v0.9.8. The dependencies were pinned in the pyproject.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants