Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made MFA mandatory for gem releases #79

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Made MFA mandatory for gem releases #79

merged 1 commit into from
Jun 24, 2022
+2 −0

Conversation

sue445
Copy link
Collaborator

@sue445 sue445 commented Jun 21, 2022

Motivation

I want to make MFA mandatory for gem security (supply chain attack)

https://blog.rubygems.org/2022/06/13/making-packages-more-secure.html

What will change after merging this PR?

MFA is requested when rake release is running

$ bundle exec rake release

(snip)

You have enabled multi-factor authentication. Please enter OTP code.
Code:

Please enable MFA on own account 🙏
https://rubygems.org/settings/edit

image

@sue445 sue445 requested a review from joker1007 June 21, 2022 13:09
joker1007
joker1007 approved these changes Jun 24, 2022
View reviewed changes
Copy link
Collaborator

@joker1007 joker1007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joker1007 joker1007 merged commit 1d1ab91 into master Jun 24, 2022
@joker1007 joker1007 deleted the rubygems_mfa_required branch June 24, 2022 06:12
@sue445
Copy link
Collaborator Author

sue445 commented Jun 24, 2022

I released v0.5.2 🚀

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joker1007 joker1007 joker1007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sue445 @joker1007