Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

widgets.php - Edit Global Class silently fails #1464

Open
iansvo opened this issue Nov 10, 2024 · 1 comment
Open

widgets.php - Edit Global Class silently fails #1464

iansvo opened this issue Nov 10, 2024 · 1 comment
Assignees
Labels
bug Bugs, unexpected and weird behaviors Global Styles

Comments

@iansvo
Copy link
Collaborator

iansvo commented Nov 10, 2024

Description

If you add a global style to a block that is in a widget area (i.e. widgets.php) and then attempt to edit it, the snackbar notice shows but the sidebar doesn't update to show you to EditClass panel.

Steps to reproduce

  1. Go to Appearance->Widgets
  2. Add a GB block to a widget area
  3. Add a global style to the block
  4. Attempt to edit that style

Expected behavior

Sidebar should show the standard EditClass component with global style controls.

Actual behavior

Snackbar notice says "editing X..." (where X is the classname) but nothing happens in the sidebar.

@iansvo iansvo added bug Bugs, unexpected and weird behaviors Global Styles labels Nov 10, 2024
@iansvo iansvo self-assigned this Nov 10, 2024
@tomusborne
Copy link
Owner

Global Styles (and our local styles) currently don't support the widget area.

You can see how we get settings here: https://github.com/tomusborne/generateblocks-pro/blob/release/1.8.0/src/global-classes/hooks/useGetSettings.js

We should likely not show the UI/show a message instead until we're able to support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs, unexpected and weird behaviors Global Styles
Projects
None yet
Development

No branches or pull requests

2 participants