[GB 2.0 pre alpha] No undo when adding element to a container or when adding an inner container

[quantumleap33]

Description

I've noticed that when adding an inner container inside an existing container or when adding an element to a container, the undo buttons do not work.

[iansvo]

@tomusborne Happy to look at this, but do you have any thoughts on why this might be happening? If we're inserting or replacing blocks I would expect the native undo would work as expected here.

I've also observed this same issue myself during my recent project and we 100% should fix it before releasing 2.0.

[tomusborne]

What you're experiencing here is core "undoing" the uniqueId generation for the block.

So, the undo is working, it's just undoing something that happened in the background.

If you undo twice, it will remove the added Container.

I'm not really sure if there's a way around this, as we need to generate a unique ID for each block added to the page.

One option is to use the __unstableMarkNextChangeAsNotPersistent() function before we set the ID, but I don't love using "unstable" functions provided by core.