Fix TENANT_LIMIT_SET_CALLS implementation #157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change introduced in #115 broke the
TENANT_LIMIT_SET_CALLS
because theDatabaseWrapper
creates a new cursor every time and so the checkself._previous_cursor != cursor
is never false.This behaviour is described in PEP 249:
and can be seen in the underlying implementation (in django.db.backends.base)
I have removed the check and also updated the tests to show the intended behaviour of the
TENANT_LIMIT_SET_CALLS
setting.I realise this will probably recreate the issue described in #114 and I tried to figure out the underlying issue but without more information it is hard to diagnose.