Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issues #10

Open
Sy3Omda opened this issue Sep 18, 2019 · 9 comments
Open

Some issues #10

Sy3Omda opened this issue Sep 18, 2019 · 9 comments

Comments

@Sy3Omda
Copy link

Sy3Omda commented Sep 18, 2019

Hi Tom,

u r building nice tool here as usal BUT i need to calrify some points to be fixed

  • CertSpotter need some filtration

  • Virus total not working at all

  • FindSubDomains not working at all

  • FetchUrlscan need some filtration

i tested each function via disable others in main.go

@leesoh
Copy link

leesoh commented Oct 1, 2019

What do you mean by filtration? Also, which domains were showing up in manual searches but not when using assetfinder?

@Sy3Omda
Copy link
Author

Sy3Omda commented Oct 8, 2019

@leesoh virustotal.go urlscan.go

@leesoh
Copy link

leesoh commented Oct 8, 2019

I'm still not sure what you mean by filtration. Can you give an example of what it's doing now and what you'd like it to be doing?

Regarding VT and FindSubDomains, have you set the VT_API_KEY and SPYSE_API_TOKEN environment variables?

@Sy3Omda
Copy link
Author

Sy3Omda commented Oct 9, 2019

i already set the apiKey for virustotal but it still not working but when i request the simple curl with my bash it is working probably as following.
curl -s "https://www.virustotal.com/vtapi/v2/domain/report?apikey=123456789&domain=$1" | jq ".subdomains[]"
123456789 = apiKey within double quotation in virustotal.go
SO if you wanna to test this:-
1- disable the other domains in main.go by commenting the function in
https://github.com/tomnomnom/assetfinder/blob/2f365f1a9316c7daabe5f17af946c86d30172770/main.go#L30

2- comment all domains except virus total for example which will be tested.
3- run go build
4- test the new assetfinder by running ./assetfinder ask.com for example .
5- you would get nothing as result although you already set your apiKey in https://github.com/tomnomnom/assetfinder/blob/2f365f1a9316c7daabe5f17af946c86d30172770/virustotal.go#L10
6- and you could test the others with that way

@Sy3Omda
Copy link
Author

Sy3Omda commented Oct 21, 2019

Hi @leesoh ,
did u figure it out!

@leesoh
Copy link

leesoh commented Oct 21, 2019

Hey there, sorry! I haven't had much time to dig into this yet :\ In the meantime, can you try tossing a fmt.Println("api key is blank") in around here: https://github.com/tomnomnom/assetfinder/blob/master/virustotal.go#L12?

@Sy3Omda
Copy link
Author

Sy3Omda commented Oct 22, 2019

it print out api key is blank or whatever u put in there!!
still not fixed

@leesoh
Copy link

leesoh commented Oct 22, 2019

OK, so that means that it's not finding the environment variable. Can you try echo $VT_API_KEY? If that is blank as well then it means the environment variable isn't set. You can fix this by doing export VT_API_KEY=<YOUR API KEY>.

@Asifkhan127001
Copy link

How to set api Key

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants