Skip to content
This repository has been archived by the owner on Sep 24, 2022. It is now read-only.

Duplicate table not detected. #279

Closed
ehuss opened this issue Jan 5, 2019 · 1 comment · Fixed by #280
Closed

Duplicate table not detected. #279

ehuss opened this issue Jan 5, 2019 · 1 comment · Fixed by #280

Comments

@ehuss
Copy link
Collaborator

ehuss commented Jan 5, 2019

The following TOML is accepted, but it should be rejected due to the duplicate table.

[dependencies.openssl-sys]
version = "0.5.2"

[dependencies]
libc = "0.1"

[dependencies]
bitflags = "0.1.1"

Discovered in these 3 Cargo.toml manifests on crates.io:

I don't think I understand the cur_parent dance in MapVisitor well enough to fix this.
alexcrichton added a commit that referenced this issue Jan 7, 2019
@alexcrichton
Fix disallowing duplicate table headers
7ee1c1b 
This commit fixes #279 where a case of duplicate table headers slipped
through the cracks. This also adds an option to disable this new
validation to allow Cargo to preserve backwards compatibility.
@alexcrichton alexcrichton mentioned this issue Jan 7, 2019
Merged
@alexcrichton
Copy link
Collaborator

I'm not sure I understand the dance well enough either, but I managed to cobble together #280!

@ehuss ehuss closed this as completed in #280 Jan 8, 2019
@dependabot dependabot bot mentioned this issue Mar 16, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix disallowing duplicate table headers toml-rs/toml-rs
2 participants
@ehuss @alexcrichton