Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discovered resources are capped at 1000 resources #1828

Closed
tomkerkhove opened this issue Nov 12, 2021 · 0 comments · Fixed by #1962
Closed

Discovered resources are capped at 1000 resources #1828

tomkerkhove opened this issue Nov 12, 2021 · 0 comments · Fixed by #1962
Assignees
@tomkerkhove
Labels
agents:discovery-agent All issues related to the resource discovery agent bug Something isn't working help-wanted All issues where people can contribute to the project
Milestone
Resource Discover...

Comments

@tomkerkhove
Copy link
Owner

tomkerkhove commented Nov 12, 2021 •
edited
Loading

Report

Discovered resources are capped at 1000 resources and ignoring the rest.

Expected Behavior

Return all resources that match the response by using the paging

Actual Behavior

Only 1000 resources are returned

Steps to Reproduce the Problem

  1. Create more than 1000 resources (see https://github.com/promitor/azure-infrastructure)
  2. Discover resources
  3. Interpret result
    ...

Component

Resource Discovery

Version

0.5.0 and below

Configuration

Configuration:

version: v1
azureLandscape:
  tenantId: e0372f7f-a362-47fb-9631-74a5c4ba8bbf
  subscriptions:
  - 63c590b6-4947-4898-92a3-cae91a31b5e4
  cloud: Global
resourceDiscoveryGroups:
- name: logic-apps-unfiltered
  type: LogicApp

Logs

N/A

Platform

No response

Contact Details

No response
@tomkerkhove tomkerkhove added the bug Something isn't working label Nov 12, 2021
@tomkerkhove tomkerkhove self-assigned this Nov 12, 2021
@tomkerkhove tomkerkhove added the agents:discovery-agent All issues related to the resource discovery agent label Nov 12, 2021
@tomkerkhove tomkerkhove moved this to Proposed in Promitor Roadmap Nov 28, 2021
@tomkerkhove tomkerkhove moved this from Proposed to Todo in Promitor Roadmap Nov 28, 2021
@tomkerkhove tomkerkhove added the help-wanted All issues where people can contribute to the project label Dec 22, 2021
@tomkerkhove tomkerkhove moved this from Todo to In Progress in Promitor Roadmap Jan 24, 2022
@tomkerkhove tomkerkhove mentioned this issue Feb 16, 2022
Merged
Repository owner moved this from In Progress to Ready To Ship in Promitor Roadmap Mar 7, 2022
@tomkerkhove tomkerkhove moved this from Ready To Ship to Done in Promitor Roadmap Apr 8, 2022
@tomkerkhove tomkerkhove mentioned this issue May 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomkerkhove tomkerkhove

Labels
agents:discovery-agent All issues related to the resource discovery agent bug Something isn't working help-wanted All issues where people can contribute to the project
Projects
Promitor Roadmap
Status: Done
Milestone
Resource Discovery - v0.7.1
Development

Successfully merging a pull request may close this issue.

fix: Provide paging through discovery groups to discover 1000+ resources tomkerkhove/promitor
1 participant
@tomkerkhove