Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide runtime configuration override via environment variables #594

Closed
tomkerkhove opened this issue Jun 17, 2019 · 3 comments
Closed
Labels
configuration All issues related to configuration enhancement Enhancements for current features

Comments

@tomkerkhove
Copy link
Owner

In #431 we've introduced our runtime YAML configuration, however, in certain scenarios, it's good to be able to override them via environment variables as suggested by @jdevalk2 in his comment.

I like the suggestion of using a similar approach to Grafana :

[server]
name=bla

Can be overridden with environment variable GF_SERVER_NAME=bla2

@tomkerkhove tomkerkhove added enhancement Enhancements for current features configuration All issues related to configuration labels Jun 17, 2019
@github-actions
Copy link

github-actions bot commented Nov 8, 2019

This issue is stale because it has been open with no activity. Remove stale label, add keep label or comment to prevent this issue from being closed in 21 days.

@github-actions github-actions bot added the stale All issues & PRs that are stale label Nov 8, 2019
@tomkerkhove
Copy link
Owner Author

@jdevalk2 Since our configuration is now a YAML file, but able to be overriden via ENV variables, can we close this one?

https://promitor.io/configuration/v1.x/runtime#overriding-configuration-with-environment-variables

@jdevalk2
Copy link

jdevalk2 commented Jan 20, 2020

@tomkerkhove Its exactly what this ticket talks about so this one can be closed. LGTM.

@tomkerkhove tomkerkhove removed the stale All issues & PRs that are stale label Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration All issues related to configuration enhancement Enhancements for current features
Projects
None yet
Development

No branches or pull requests

2 participants