Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for hot-swapping scraping configuration #573

Open
tomkerkhove opened this issue May 22, 2019 · 4 comments
Open

Provide support for hot-swapping scraping configuration #573

tomkerkhove opened this issue May 22, 2019 · 4 comments
Labels
agents:scraper All issues related to the scraping agent configuration All issues related to configuration enhancement Enhancements for current features scraping All issues related to scraping

Comments

@tomkerkhove
Copy link
Owner

Provide support for hot-swapping scraping configuration so that agent does not need to be restarted.

@tomkerkhove tomkerkhove added enhancement Enhancements for current features configuration All issues related to configuration scraping All issues related to scraping labels May 22, 2019
@brusMX
Copy link
Contributor

brusMX commented Jun 26, 2019

This is a feature that our customers would like to have.

Because they need to be able to change the metrics on the fly without having to restart the service or re-deploy it.

They want it to be fully independent and decouple so it can live even if the service is down and continue to work even if the service is deployed after Promitor was deployed.

Also they want to make sure that Promitor will start fetching new metrics the moment metrics.config file is updated.

@tomkerkhove tomkerkhove added this to the v1.0.0 milestone Jul 8, 2019
@tomkerkhove
Copy link
Owner Author

tomkerkhove commented Jul 8, 2019

This will be done as part of #431 via #608 for runtime configuration but not for scraping configuration.

@tomkerkhove
Copy link
Owner Author

We should move the validation inside the deserialization somehow rather than based on the output - see @adamconnelly his suggestion

@github-actions
Copy link

github-actions bot commented Nov 8, 2019

This issue is stale because it has been open with no activity. Remove stale label, add keep label or comment to prevent this issue from being closed in 21 days.

@github-actions github-actions bot added the stale All issues & PRs that are stale label Nov 8, 2019
@tomkerkhove tomkerkhove added this to the v1.4.0 milestone Jan 16, 2020
@tomkerkhove tomkerkhove modified the milestones: v1.4.0, v1.5.0 Jan 30, 2020
@tomkerkhove tomkerkhove modified the milestones: v1.5.0, v1.6.0 Mar 17, 2020
@tomkerkhove tomkerkhove removed the stale All issues & PRs that are stale label Mar 17, 2020
@tomkerkhove tomkerkhove removed this from the v1.6.0 milestone Mar 23, 2020
@tomkerkhove tomkerkhove added the agents:scraper All issues related to the scraping agent label Apr 21, 2020
@tomkerkhove tomkerkhove moved this to Proposed in Promitor Roadmap May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents:scraper All issues related to the scraping agent configuration All issues related to configuration enhancement Enhancements for current features scraping All issues related to scraping
Projects
Status: Proposed
Development

No branches or pull requests

2 participants