Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide support for scraping metrics for Azure ExpressRoute circuits #1251

Closed
bluepixbe opened this issue Aug 31, 2020 · 4 comments · Fixed by #1254
Closed

Provide support for scraping metrics for Azure ExpressRoute circuits #1251

bluepixbe opened this issue Aug 31, 2020 · 4 comments · Fixed by #1254
Labels
metric-source:azure-monitor All issues that relate to scraping metrics that depends on Azure Monitor as a data source scraper-source All issues related to new scraper sources from Azure Monitor scraping All issues related to scraping

Comments

@bluepixbe
Copy link
Contributor

bluepixbe commented Aug 31, 2020 •
edited
Loading

Provide support for scraping metrics for Azure ExpressRoute circuits

If you are fine I think I could soon push a PR for that.
@tomkerkhove
Copy link
Owner

That's a fair ask and I'm more than happy to review a PR!

We have some docs on how to contribute and how to add a new scraper.

@tomkerkhove tomkerkhove added metric-source:azure-monitor All issues that relate to scraping metrics that depends on Azure Monitor as a data source scraper-source All issues related to new scraper sources from Azure Monitor scraping All issues related to scraping labels Aug 31, 2020
@bluepixbe
Copy link
Contributor Author

@tomkerkhove cool. Thanks for the links.

Code/docs should be ready. Tests are looking good and the metrics were properly collected.

The only issue I face now while pushing the branch is a 403.. Will try to check tomorrow.

@tomkerkhove
Copy link
Owner

Thanks! Normally that's because you try to push to this repo instead of your fork? Can you check please?

@bluepixbe bluepixbe mentioned this issue Sep 1, 2020
Merged
@bluepixbe
Copy link
Contributor Author

@tomkerkhove Thanks for your hint. But I had somehow a mess with my git credentials (private & corporate users) in the windows credentials manager. Finally it worked. I pushed it with the wrong user but that doesn't matter ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
metric-source:azure-monitor All issues that relate to scraping metrics that depends on Azure Monitor as a data source scraper-source All issues related to new scraper sources from Azure Monitor scraping All issues related to scraping
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide support for scraping metrics for Azure ExpressRoute circuits bluepixbe/promitor
2 participants
@tomkerkhove @bluepixbe