Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename resource collections to resource discovery groups #1031

Closed
tomkerkhove opened this issue May 13, 2020 · 2 comments · Fixed by #1141
Closed

Rename resource collections to resource discovery groups #1031

tomkerkhove opened this issue May 13, 2020 · 2 comments · Fixed by #1141
Labels
agents:discovery-agent All issues related to the resource discovery agent configuration All issues related to configuration enhancement Enhancements for current features
Milestone
Scraper - v2.0.0

Comments

@tomkerkhove
Copy link
Owner

Rename resource collections to resource discovery groups as it feels more natural.
@tomkerkhove tomkerkhove added this to the v1.7.0 milestone May 13, 2020
@tomkerkhove tomkerkhove added agents:discovery-agent All issues related to the resource discovery agent enhancement Enhancements for current features configuration All issues related to configuration and removed triage labels May 13, 2020
@tomkerkhove
Copy link
Owner Author

tomkerkhove commented Jun 25, 2020 •
edited
Loading

Should we? What name makes more sense?

They describe a group of resources that will be discovered based on criteria, for example:

- name: app-services-north-europe
  type: WebApp
  criteria:
    regions:
    - northeurope

@adamconnelly
Copy link
Contributor

I think this makes sense - it's a better description of the purpose.

@tomkerkhove tomkerkhove mentioned this issue Jul 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agents:discovery-agent All issues related to the resource discovery agent configuration All issues related to configuration enhancement Enhancements for current features
Projects
None yet
Milestone
Scraper - v2.0.0
Development

Successfully merging a pull request may close this issue.

Rename resource collections to resource discovery groups tomkerkhove/promitor
2 participants
@adamconnelly @tomkerkhove