Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-dom dependency not properly declared #40

Closed
basilveerman opened this issue Oct 31, 2015 · 2 comments
Closed

react-dom dependency not properly declared #40

basilveerman opened this issue Oct 31, 2015 · 2 comments

Comments

@basilveerman
Copy link

Current requirement as a development dependency results in errors when required by other packages:

ERROR in .//react-bootstrap-table//react-toastr/lib/ToastMessage/animationMixin.js
Module not found: Error: Cannot resolve module 'react-dom' in /home/bveerman/code/climate-explorer/client/node_modules/react-bootstrap-table/node_modules/react-toastr/lib/ToastMessage
@ .//react-bootstrap-table//react-toastr/lib/ToastMessage/animationMixin.js 5:15-35

Changes introduced in e8b7152 require react-dom as a dependency.
@jerairrest
Copy link
Contributor

Good catch. You are correct. ReactDOM was introduced in React 0.14 as a dependency since React.render is now deprecated. React-dom should be a peer dependency. I'll get a PR request for this asap.

Jer

tomchentw referenced this issue Nov 2, 2015
@tomchentw
fix(package.json): added react-dom as dependency
18c58d0 
* Original commit: 8a31d7d
* Original author: @jerairrest
* Closes #41
@tomchentw
Copy link
Owner

Thanks the PR #41 by @jerairrest ! Current up to date version is v2.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tomchentw @jerairrest @basilveerman