Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update dependencies & fix deprecated for React 16 #108

Closed
wants to merge 2 commits into from

Conversation

KagamiChan
Copy link
Contributor

@KagamiChan KagamiChan commented Aug 9, 2017

to make react-toastr compatible with future React 16:

  • updated React to 15.6.1
  • removed react-addons-test-utils since it is deprecated in favor of
    react-dom/test-utils and react-test-renderer
  • removed react-addons-update since it is deprecated in favor of
    immutability-helper
  • added create-react-class to replace React.createClass
  • added prop-types since React will no longer ships with it
  • created transitionEvents.js to provide transition event
    compatibility

Have to say that this version of transitionEvents.js borrows many ideas from Facebook's original codes, don't know whether I should place a license in it

fixes #95
fixes #94
fixes #86

to make react-toastr compatible with future React 16:
- updated React to 15.6.1
- removed react-addons-test-utils since it is deprecated in favor of
react-dom/test-utils and react-test-renderer
- removed react-addons-update since it is deprecated in favor of
immutability-helper
- added create-react-class to replace React.createClass
- added prop-types since React will no longer ships with it
- created transitionEvents.js to provide transition event
compatibility
@KagamiChan
Copy link
Contributor Author

pinging @tomchentw

@tomchentw
Copy link
Owner

I'll land #109 first, and look into what you've done for #86 later. Thanks

tomchentw pushed a commit that referenced this pull request Aug 21, 2017
tomchentw pushed a commit that referenced this pull request Aug 21, 2017
@tomchentw tomchentw mentioned this pull request Aug 21, 2017
@tomchentw tomchentw closed this in b3423a9 Aug 21, 2017
@tomchentw
Copy link
Owner

Released v2.9.1

@KagamiChan
Copy link
Contributor Author

Good job, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants