Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to Gerrit 2.11.3 #8

Closed
tomaswolf opened this issue Aug 20, 2015 · 1 comment
Closed

Adapt to Gerrit 2.11.3 #8

tomaswolf opened this issue Aug 20, 2015 · 1 comment
Assignees

Comments

@tomaswolf
Copy link
Owner

Gerrit 2.11.3 release is imminent; probably the week-end of Aug 21-23. The plugin will need to be adapted. Refactorings needed:

  • change dependency to gerrit-api 2.11.3.
  • remove direct dependencies on parboiled in Gitblit code (some isolated and completely unnecessary instances).
  • check that markdown rendering still works (Gerrit 2.11.3 replaces parboiled by grappa 1.0.4). Should be compatible, but one never knows. If it doesn't work, re-include a relocated pegdown/parboiled combo in the shaded jar for use by Gitblit.
  • Gerrit 2.11.3 switches to Guice 4.0; we should be able to remove the FixedGuiceHttpServletRequest.

New release of this plugin should be ready at most a few days after Gerrit 2.11.3 has been released.

@tomaswolf tomaswolf self-assigned this Aug 20, 2015
@tomaswolf
Copy link
Owner Author

Done in release v2.11.3.162.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant