Skip to content
This repository has been archived by the owner on Jun 9, 2021. It is now read-only.

Commit

Permalink
Showing description for input and textarea in buttons form #190
Browse files Browse the repository at this point in the history
  • Loading branch information
tomasbjerre committed Jan 30, 2017
1 parent cefc0c9 commit c3df65f
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 4 deletions.
25 changes: 24 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,35 @@
Changelog of Pull Request Notifier for Bitbucket.

## Unreleased
### GitHub [#190](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/issues/190) button forms: descriptions not showing for types input and textarea
Showing description for input and textarea in buttons form

[11175eea4da9eba](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/commit/11175eea4da9eba) Tomas Bjerre *2017-01-30 18:22:11*

### No issue
Doc

[cefc0c985ac96ae](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/commit/cefc0c985ac96ae) Tomas Bjerre *2017-01-29 16:25:48*

Fiddling with Docker

[a674860740e4e90](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/commit/a674860740e4e90) Tomas Bjerre *2017-01-29 14:52:39*

## 2.49
### GitHub [#187](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/issues/187) Support HTML escaping in variable expansion?
Adding HipChat documentation

* The HipChat docs were privided by [Rychard](https://github.com/Rychard).
* Moving Jenkins docs to its own file.
* Moving issue reporting guidelines to ISSUE_TEMPLATE.

[f6e6fe6953e57b6](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/commit/f6e6fe6953e57b6) Tomas Bjerre *2017-01-28 13:45:12*

Optionally HTML encode variables in post content

* Also adding a .gitattributes to force line endings

[6c5ea57e189e213](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/commit/6c5ea57e189e213) Tomas Bjerre *2017-01-28 13:24:47*
[51f4c6041458893](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/commit/51f4c6041458893) Tomas Bjerre *2017-01-28 13:29:33*

### No issue
Use table instead of list for variable documentation
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,8 @@ You may use Chrome and Developer Tools (press F12) to view rest calls while edit

## Integration guides

Generally, when working fiddling with this plugin, you may want to use something like [RequestBin](https://requestb.in/). Let the notification URL point to it and you can inspect what the invoked URL looks like.

Here are some guides on how to use the plugin with different systems. Feel free to add guides through pull requests to this repo!

* [Jenkins](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/blob/master/README_jenkins.md)
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/admin.vm
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@


<h4>URL</h4>
<p>The URL to invoke when notification is triggered.</p>
<p>The URL to invoke when notification is triggered. You may want to try <a href="https://requestb.in/" target="_blank">RequestBin</a> to fiddle with the plugin settings.</p>
<fieldset class="group">
<div class="field-group">
<label>URL </label>
Expand Down
4 changes: 2 additions & 2 deletions src/main/resources/pr-triggerbutton.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ define('plugin/prnfb/pr-triggerbutton', [
var escapedName = _.escape(name);
var escapedLabel = _.escape(item.label);
var escapedValue = _.escape(item.defaultValue);
var escapedDescription = _.escape(item.defaultDescription);
var escapedDescription = _.escape(item.description);
return $('' +
'<div class="field-group">' + //
'<label for="' + name + '">' + escapedLabel + //
Expand All @@ -60,7 +60,7 @@ define('plugin/prnfb/pr-triggerbutton', [
var escapedName = _.escape(name);
var escapedLabel = _.escape(item.label);
var escapedValue = _.escape(item.defaultValue);
var escapedDescription = _.escape(item.defaultDescription);
var escapedDescription = _.escape(item.description);
return $('' +
'<div class="field-group">' + //
'<label for="' + escapedName + '">' + escapedLabel + //
Expand Down

0 comments on commit c3df65f

Please sign in to comment.