Using boolean for defaultValue in ButtonFormElementOption #178

CHANGELOG.md

@@ -3,10 +3,19 @@
 Changelog of Pull Request Notifier for Bitbucket.
 
 ## Unreleased
+### GitHub [#178](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/issues/178) Forms with checkboxes that have a default value of false do not work
+  Using boolean for defaultValue in ButtonFormElementOption
+
+  [edbe86ab15b83f0](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/commit/edbe86ab15b83f0) Tomas Bjerre *2017-01-03 08:06:27*
+
 ### No issue
+  fixed jenkins plugin url
+
+  [6fafc078851d1e4](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/commit/6fafc078851d1e4) Rishabh Tayal *2016-12-28 17:45:34*
+
   Doc
 
-  [68eeb5d1bdfc508](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/commit/68eeb5d1bdfc508) Tomas Bjerre *2016-12-27 10:42:37*
+  [aef9959f68fa4e4](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/commit/aef9959f68fa4e4) Tomas Bjerre *2016-12-27 10:42:56*
 
 ## 2.45
 ### GitHub [#173](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/pull/173) Add the ability to specify forms for buttons

src/main/java/se/bjurr/prnfb/presentation/dto/ButtonFormElementOptionDTO.java

@@ -11,9 +11,9 @@
 public class ButtonFormElementOptionDTO {
   private String label;
   private String name;
-  private String defaultValue;
+  private Boolean defaultValue;
 
-  public void setDefaultValue(String defaultValue) {
+  public void setDefaultValue(Boolean defaultValue) {
     this.defaultValue = defaultValue;
   }
 
@@ -25,7 +25,7 @@ public void setName(String name) {
     this.name = name;
   }
 
-  public String getDefaultValue() {
+  public Boolean getDefaultValue() {
     return defaultValue;
   }
 

src/main/java/se/bjurr/prnfb/settings/PrnfbButtonFormElementOption.java

@@ -1,20 +1,19 @@
 package se.bjurr.prnfb.settings;
 
 import static com.google.common.base.Preconditions.checkNotNull;
-import static com.google.common.base.Strings.emptyToNull;
 
 public class PrnfbButtonFormElementOption {
   private final String label;
   private final String name;
-  private final String defaultValue;
+  private final Boolean defaultValue;
 
-  public PrnfbButtonFormElementOption(String label, String name, String defaultValue) {
+  public PrnfbButtonFormElementOption(String label, String name, Boolean defaultValue) {
     this.label = checkNotNull(label, "label");
     this.name = checkNotNull(name, "name");
-    this.defaultValue = emptyToNull(defaultValue);
+    this.defaultValue = defaultValue;
   }
 
-  public String getDefaultValue() {
+  public Boolean getDefaultValue() {
     return defaultValue;
   }