Skip to content
This repository has been archived by the owner on Jun 9, 2021. It is now read-only.

Commit

Permalink
Only select checkboxes marked as default true in button forms #178
Browse files Browse the repository at this point in the history
  • Loading branch information
tomasbjerre committed Jan 3, 2017
1 parent 5c4fa28 commit 65de828
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
8 changes: 7 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,16 @@
Changelog of Pull Request Notifier for Bitbucket.

## Unreleased
### GitHub [#178](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/issues/178) Forms with checkboxes that have a default value of false do not work
Only select checkboxes marked as default true in button forms

[c67aac2253b2fef](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/commit/c67aac2253b2fef) Tomas Bjerre *2017-01-03 17:32:10*

## 2.46
### GitHub [#178](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/issues/178) Forms with checkboxes that have a default value of false do not work
Using boolean for defaultValue in ButtonFormElementOption

[edbe86ab15b83f0](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/commit/edbe86ab15b83f0) Tomas Bjerre *2017-01-03 08:06:27*
[857b440e069912f](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/commit/857b440e069912f) Tomas Bjerre *2017-01-03 08:09:39*

### No issue
fixed jenkins plugin url
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/pr-triggerbutton.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ define('plugin/prnfb/pr-triggerbutton', [
var itemName = _.escape(nestedItem.name);
var itemLabel = _.escape(nestedItem.label);
return $('<div class="checkbox">' + //
'<input class="checkbox" value="' + itemName + '" type="checkbox" checked=' + (isChecked ? '"checked"' : '""') + //
'<input class="checkbox" value="' + itemName + '" type="checkbox" ' + (isChecked ? 'checked="checked"' : '') + //
' name="' + outerName + '[]" id="prnfb-form-' + outerName + '-' + num + '">' + //
'<label for="prnfb-form-' + outerName + '-' + num + '"' + //
'>' + itemLabel + '</label></div>');
Expand Down

0 comments on commit 65de828

Please sign in to comment.