New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shapely 2.0 compatibility #56

Closed

thomas-fred opened this issue Jul 25, 2022 · 1 comment

Collaborator

thomas-fred commented Jul 25, 2022

Things we need to amend for shapely 2.0 compatibility:

When shapley.ops.split fails (e.g. on split by empty geometry collection) this is currently caught by snkit.network.split_edge_at_points with ValueError. However it this won't work for shapely==2.0, as: "GeometryTypeError will derive from ShapelyError and not TypeError or ValueError in Shapely 2.0." Review codebase to see if we catch other exceptions in a deprecated way.

The text was updated successfully, but these errors were encountered:

Owner

tomalrussell commented Jun 9, 2023

Closed by e686e90

Testing with shapely>=2.0 as of f3dd5c4

tomalrussell closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment