Remove wireguard-tools from wireguard

[Eeems]

• Make wireguard depend on wireguard-tools
• Remove wireguard-tools from wireguard

[bkirwi]

Poked around at this a bit. Keep in mind I have no direct wireguard experience.

First thing: before installing the packages on this branch I installed wireguard and wireguard-tools from the testing branch.

reMarkable: ~/ opkg install wireguard
Installing wireguard (1.0.20210219-3) to root...
Downloading https://toltec-dev.org/testing/rmall/wireguard_1.0.20210219-3_rmall.ipk
Configuring wireguard.
reMarkable: ~/ opkg install wireguard-tools
Installing wireguard-tools (1.0.20210914-2) to root...
Downloading https://bin.entware.net/armv7sf-k3.2/wireguard-tools_1.0.20210914-2_armv7-3.2.ipk
Installing libnl-tiny (2023-07-27-bc92a280-1) to root...
Downloading https://bin.entware.net/armv7sf-k3.2/libnl-tiny_2023-07-27-bc92a280-1_armv7-3.2.ipk
Installing ip-full (4.4.0-10a) to root...
Downloading https://bin.entware.net/armv7sf-k3.2/ip-full_4.4.0-10a_armv7-3.2.ipk
Configuring libnl-tiny.
Configuring ip-full.
Configuring wireguard-tools.

Note that wireguard comes via toltec, but wireguard-tools comes via the entware repo. And then

opkg install wireguard-tools_1.0.20210914-2_rmall.ipk
Package wireguard-tools (1.0.20210914-2) installed in root is up to date.

Because the upstream wireguard has the exact same version number presumably. Removing it and installing the toltec version worked fine. But it did make me wonder whether we're giving ourselves trouble shadowing a package like this... maybe we should arrange things so the toltec versions are always preferred?

Second thing:

reMarkable: ~/toltec-test/wireguard/ opkg files wireguard
Package wireguard (1.0.20210219-4) is installed on root and has the following files:
/lib/modules/4.9.84-zero-gravitas/kernel/net/ipv6/ip6_udp_tunnel.ko
/lib/modules/4.9.84-zero-gravitas/kernel/net/ipv4/udp_tunnel.ko
/lib/modules/4.9.84-zero-gravitas/extra/wireguard.ko
/lib/modules/4.14.78/kernel/net/ipv4/udp_tunnel.ko
/lib/modules/4.14.78/extra/wireguard.ko
/lib/modules/4.14.78/kernel/net/ipv6/ip6_udp_tunnel.ko
reMarkable: ~/toltec-test/wireguard/ modprobe wireguard
modprobe: FATAL: Module wireguard not found in directory /lib/modules/5.4.70-v1.1.5-rm11x
reMarkable: ~/toltec-test/wireguard/ ls /lib/modules/
4.14.78               4.9.84-zero-gravitas  5.4.70-v1.1.5-rm11x

Do we need to build for a third kernel?

[Eeems]

This might help explain why things aren't working as I expected when I was testing the stable merge. We either need to drop the package, or add an epoch to the version number to make sure it always installs ours. The priority on the rm2 arch should be enough to also force ours to be installed, but apparently not so.

As for wireguard not working properly in 2.15.1, this is a known issue (#506) which is why #759 is dropping the package for 3.x support. You can also find a PR that has been open for over 12 months now (#651), updating the wireguard package as well as the kernel version it builds against to 5.4.70.

[bkirwi]

reMarkable: ~/toltec-test/ opkg install wireguard_1.0.20210219-4_rmall.ipk 
Upgrading wireguard on root from 1.0.20210219-3 to 1.0.20210219-4...
Wireguard has been upgraded.
The old kernel module will remain loaded until you reboot, or you can
attempt to manually remove it by running "modprobe -r wireguard".
Removing obsolete file /usr/bin/wg-quick.
Removing obsolete file /lib/systemd/system/wg-quick.target.
Removing obsolete file /usr/bin/wg.
Removing obsolete file /usr/share/man/man8/wg.8.
Removing obsolete file /usr/share/man/man8/wg-quick.8.
Removing obsolete file /lib/systemd/system/[email protected].
Configuring wireguard.

Packaging looks good to me!