-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracing, tracing-futures: instrument Future
inside Drop
#2562
Merged
Commits on Apr 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f0cc5d1 - Browse repository at this point
Copy the full SHA f0cc5d1View commit details -
subscriber: add ability to disable ANSI without crate feature (tokio-…
…rs#2532) ## Motivation Currently it is not possible to disable ANSI in `fmt::Subscriber` without enabling the "ansi" crate feature. This makes it difficult for users to implement interoperable settings that are controllable with crate features without having to pull in the dependencies "ansi" does. I hit this while writing an application with multiple logging options set during compile-time and I wanted to cut down on dependencies if possible. ## Solution This changes `fmt::Subscriber::with_ansi()` to not require the "ansi" feature flag. This way, `with_ansi(false)` can be called even when the "ansi" feature is disabled. Calling `with_ansi(true)` when the "ansi" feature is not enabled will panic in debug mode, or print a warning if debug assertions are disabled. Co-authored-by: Eliza Weisman <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1cb523b - Browse repository at this point
Copy the full SHA 1cb523bView commit details
Commits on Apr 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a0b5166 - Browse repository at this point
Copy the full SHA a0b5166View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38620f6 - Browse repository at this point
Copy the full SHA 38620f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for abcb488 - Browse repository at this point
Copy the full SHA abcb488View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41c10bd - Browse repository at this point
Copy the full SHA 41c10bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for e1d6d4e - Browse repository at this point
Copy the full SHA e1d6d4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 813bd3e - Browse repository at this point
Copy the full SHA 813bd3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b961057 - Browse repository at this point
Copy the full SHA b961057View commit details -
Configuration menu - View commit details
-
Copy full SHA for b24f383 - Browse repository at this point
Copy the full SHA b24f383View commit details -
Configuration menu - View commit details
-
Copy full SHA for daf27b5 - Browse repository at this point
Copy the full SHA daf27b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95f4ed7 - Browse repository at this point
Copy the full SHA 95f4ed7View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8b56a8 - Browse repository at this point
Copy the full SHA c8b56a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73e73a9 - Browse repository at this point
Copy the full SHA 73e73a9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.